ListDetailsView.ListPaneWidth Null check fix#4738
Merged
michael-hawker merged 1 commit intomainfrom Sep 2, 2022
Merged
Conversation
List Details View NRE check
|
Thanks LalithaNadimpalli for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested a review
from 
ghost
added
bug 🐛
Arlodotexe
approved these changes
Sep 1, 2022
Member
Arlodotexe
left a comment
Arlodotexe
left a comment
There was a problem hiding this comment.
Repro'd the issue, swapped the nuget package for this branch locally, and the issue was fixed.
Looks good!
michael-hawker
approved these changes
Sep 2, 2022
delete-merged-branch
bot
deleted the
ListDetailsView.ListPaneWidth-NRE-fix
branch
13 tasks
|
ListPaneWidth crashes with NullReferenceException. Issue still exists in WinUI3 Microsoft.WindowsAppSDK 1.5.240311000, Microsoft.UI.Xaml 2.8.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List Details View NRE check
Fixes #4357
PR Type
What kind of change does this PR introduce?
< Bugfix >
< Sample app changes >
What is the current behavior?
<_TwoPaneView passed without checking for null>
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements: